feat: better image handling (auto resize & max size constraints)#26401
Merged
Conversation
Collaborator
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
Author
|
/review |
Collaborator
Author
|
/review |
Collaborator
Author
|
/review |
rekram1-node
force-pushed
the
image-handling
branch
from
c76a6f9 to
0f1a4f6
Compare
Collaborator
Author
|
/review |
Collaborator
Author
|
/review |
| { message: info, parts: resolvedParts }, | ||
| ) | ||
|
|
||
| const parts = yield* Effect.forEach(resolvedParts, (part) => |
Contributor
There was a problem hiding this comment.
Suggestion for human discretion: this normalizes only the current prompt parts before they are saved, so an oversized image that is already stored in session history can still be replayed unchanged on the next model call. That leaves the unrecoverable-history case from #23570 in place for existing sessions or any bypassed path; consider adding a replay-time safeguard in MessageV2.toModelMessagesEffect to normalize or omit oversized media before sending it to the provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23570, #12068